At revision 609. Buildfile: build.xml clean: [delete] Deleting directory /opt/svn/google-caja/src/ant-reports [delete] Deleting directory /opt/svn/google-caja/src/ant-docs [delete] Deleting directory /opt/svn/google-caja/src/ant-instr [delete] Deleting directory /opt/svn/google-caja/src/ant-jars [delete] Deleting directory /opt/svn/google-caja/src/ant-lib [delete] Deleting directory /opt/svn/google-caja/src/ant-www BUILD SUCCESSFUL Total time: 0 seconds we can't use UnicodeSet [:Cf:] since IE 6 and other rewrite with a transition table or just use ANTLR need unittests undo CL 5667265 changes. separate this into two factories in separate files, this should probably be replaced with something Make a better guess at encoding. We have a few CSS2.1 has changed lexical conventions to effectively The !important is supposed to be significant this may be premature. If needed, We could resolve the href attribute relative to globalProps.url? resolve the href attribute relative to globalProps.url? other url node/attrib pairs? according to section 4.3.10 don't need a list here the spec is not clear on this. Treat the week filter byWeekNo and write unit tests filter byWeekNo and write unit tests if count is large, we might try predicting the end warn if we allow iteration more frequently than daily apply byhour, byminute, bysecond rules here write me write me This key logic belongs in spring-graph.js make indent private and add setter&getter rename this to CommonMessageType and rename replace these public fields with getters & setters to Provide a detailed dump of the bindings in the exception The 'multiDeclaration' implementation is hard disallow this if the rendercontext specifies XML check against XML&HTML definitions of whitespace. if this is not a tagend, then we should make sure that the XmlElementStack does not allow unescape attribute value || is supposed to match multiple of its elements but Javadoc. Javadoc. Javadoc. Javadoc. Javadoc. Javadoc. Javadoc. Javadoc. Javadoc. maybe enforce the convention that there are matched Is there any value in enumerating elements? is that a double negative? another double negative? elements that have table header information, What about http://www.w3.org/TR/REC-CSS2/descidx.html? http://www.w3.org/TR/REC-CSS2/ui.html#system-colors breaksReaching should probably take a paremeter of type rename breaks and continues to collectBreakTargets and check that name is a valid identifier rendering of numeric literals should not depend on the find some way of rendering NaN and Infinity in a way Investigate whether use of continue to a non loop Do we want to remove labelling of non-loop statements Erase the distinction between LabeledStmtWrapper and move unescaping to Escaping.java -- nobody will look there duplicate the code that make sure we warn on DecimalLiterals that have leading is parseDouble locale independent? maybe reliably throw an exception type, that includes is this correct? Consider a more generic representation that still guards against Sanitize and escape text in attribute values. Rename this class because it's not a parser. replace "may be null" and "not null" shorthands with replace with com.google.common.Predicate and the return an Object like { unlock: ..., constructor } build up a list of classes and ids for use in this shares a lot of code with GxpCompiler and the two replace with DOMita, and replace wrap_capability with turn event into a capability should we allow mailto urls? figure out what to do about Safari bug Implement maybe whitelist the color names defined for CSS if the arg is a capabilities for CSS snippets so CSS templates can be used Remove this and allow client custom whitelists. Remove this and allow client custom whitelists. Remove this and allow client custom whitelists. rdub disabled this condition. Am leaving it in. Handle using HTML4, which does not allow 'id' here. Review other ways SCRIPT.innerHTML may be modified. Handle using HTML4, which does not allow 'id' here. replace with a CLI parsing library. flesh out Whitelist attributes, by tag. integrate cajita compiler to allow arbitrary determine mime type properly. sanitize css if opt_keyAttrib, could implement getNamedItem for RCDATA we only need to escape & if they're not rewrite ids make sure event doesn't propagate to dispatched make sure that there is only one instance of an whitelist attributes, by tag check argument if child now instanceof FunctionLiteral Do not trim around <gxp:eval>. Trim around it if there is use the proper rewriting rule for this when ihab Put url in the appropriate file-space namespace replace instances of this in handler parameterize the whitelist Could try to enforce these constraints at runtime or use a culprit message group here? better file positions for error messages. cajole the scripts so that for loops work. --> implement hourly iteration implement minutely iteration implement minutely iteration is this right? check advancement of more examples check that these answers are right cajole the scripts so that for loops work. --> - do we need a special test for this? is x2v working" - wait on MarkM to figure out what\'s up with this test." not sure about this test - not sure about this one -->", - I don\'t think attendee stuff is implemented in X2V" - should \'REQ-PARTICIPANT be lc\'ed? -->", - should mailto: be here? -->", - ask MarkM about this. Did he mean to use <del>? -->", - review the x2v formatting stuff for DESCRIPTION" -->", - eh? -->", implement RRULE -->", cajole the scripts so that for loops work. --> cajole the scripts so that for loops work. --> cajole the scripts so that for loops work. --> Enable when http://code.google.com/p/google-caja/issues/detail?id=68 fixed Enable when http://code.google.com/p/google-caja/issues/detail?id=68 fixed Enable when http://code.google.com/p/google-caja/issues/detail?id=68 fixed Enable when http://code.google.com/p/google-caja/issues/detail?id=68 fixed Enable when http://code.google.com/p/google-caja/issues/detail?id=68 fixed This spurious LINT message is because 'foo' is this error message seems to be a bug. Test rendering of !important and combinators in selectors. test rendering of @imports, @page, @font-face, test rendering of unicode range literals. test signature parse trees test getSymbol better comment each of the test input files. Check on proper format for 'location' UserPrefs --> maybe actually diff using maybe actually diff using maybe replace this with the JSR 223 stuff. do this properly add a testcase for the exploit where __underlying__ is Re-enable code or delete entirely depending on whether we Bug: Allowing <tt>that</tt> to have a valueOf() BUG: allowDelete is not yet specified or implemented. BUG: This is not yet supported. The precise eabling BUG: This is not yet supported. The precise eabling BUG: This is not yet supported. The precise eabling BUG: This is not yet supported. The precise enabling return a builder object that allows further initialization. Need to figure out how to allow these safely. figure out how to do this properly! fix catch block when exceptions sanitized test output value Test that we get meaningful file positions out of the crashes cajoler. Make sure this doesn't pass. Make sure this doesn't pass. Make sure this doesn't pass. need return in inner closure. replace with a reparse and structural comparison. why are none of these blocked? make sure _ is not in the protected namespace. should this be available? should this be available? Remove this and allow client custom whitelists. Make final decision whether to keep or remove. This test was Buildfile: build.xml dirs: [mkdir] Created dir: /opt/svn/google-caja/src/ant-reports [mkdir] Created dir: /opt/svn/google-caja/src/ant-docs [mkdir] Created dir: /opt/svn/google-caja/src/ant-instr [mkdir] Created dir: /opt/svn/google-caja/src/ant-jars [mkdir] Created dir: /opt/svn/google-caja/src/ant-lib [mkdir] Created dir: /opt/svn/google-caja/src/ant-www Primitives: [javac] Compiling 17 source files to /opt/svn/google-caja/src/ant-lib Reporting: [javac] Compiling 10 source files to /opt/svn/google-caja/src/ant-lib Lexer: [javac] Compiling 29 source files to /opt/svn/google-caja/src/ant-lib Parser: [javac] Compiling 4 source files to /opt/svn/google-caja/src/ant-lib CssParserCore: [javac] Compiling 4 source files to /opt/svn/google-caja/src/ant-lib HtmlParserCore: [javac] Compiling 10 source files to /opt/svn/google-caja/src/ant-lib HtmlSchema: [javac] Compiling 3 source files to /opt/svn/google-caja/src/ant-lib JsParserBase: JsParserCore: Quasiliterals: [javac] Compiling 17 source files to /opt/svn/google-caja/src/ant-lib Config: [javac] Compiling 3 source files to /opt/svn/google-caja/src/ant-lib PluginCompiler: [javac] Compiling 29 source files to /opt/svn/google-caja/src/ant-lib [copy] Copying 2 files to /opt/svn/google-caja/src/ant-lib opensocial: [javac] Compiling 13 source files to /opt/svn/google-caja/src/ant-lib BUILD SUCCESSFUL Total time: 10 seconds Buildfile: build.xml dirs: emma: dirs: Primitives: Reporting: Lexer: Parser: CssParserCore: HtmlParserCore: HtmlSchema: JsParserBase: JsParserCore: Quasiliterals: Config: PluginCompiler: opensocial: pluginc: [unjar] Expanding: /opt/svn/google-caja/src/third_party/java/jakarta_commons/commons-cli.jar into /opt/svn/google-caja/src/ant-lib [unjar] Expanding: /opt/svn/google-caja/src/third_party/java/htmlparser/htmlparser.jar into /opt/svn/google-caja/src/ant-lib [jar] Building jar: /opt/svn/google-caja/src/ant-jars/pluginc.jar [jar] Building jar: /opt/svn/google-caja/src/ant-jars/pluginc-src.jar PluginCapabilities: [copy] Copying 1 file to /opt/svn/google-caja/src/ant-lib TestUtil: [javac] Compiling 3 source files to /opt/svn/google-caja/src/ant-lib CajoledTests: [java] LOG:Checkpoint: ValidateCssStage at T+0.179858 seconds [java] LOG:Checkpoint: CompileGxpsStage at T+0.18413 seconds [java] LOG:Checkpoint: CompileCssTemplatesStage at T+0.200552 seconds [java] LOG:Checkpoint: ConsolidateCodeStage at T+0.200617 seconds [java] LOG:Checkpoint: ValidateJavascriptStage at T+0.203596 seconds [java] LOG:Checkpoint: ConsolidateCssStage at T+1.045836 seconds [java] LOG:Checkpoint: CheckForErrorsStage at T+1.0459 seconds AllTests: [javac] Compiling 39 source files to /opt/svn/google-caja/src/ant-lib [copy] Copying 103 files to /opt/svn/google-caja/src/ant-lib runtests: [instr] processing instrumentation path ... [instr] instrumentation path processed in 1457 ms [instr] [515 class(es) instrumented, 242 resource(s) copied] [instr] metadata merged into [/opt/svn/google-caja/src/ant-reports/coverage/metadata.em] {in 380 ms} [mkdir] Created dir: /opt/svn/google-caja/src/ant-reports/tests [junit] Running com.google.caja.AllTests [junit] Tests run: 384, Failures: 14, Errors: 0, Time elapsed: 51.386 sec [junit] Test com.google.caja.AllTests FAILED [report] processing input files ... [report] 2 file(s) read and merged in 146 ms [report] writing [html] report to [/opt/svn/google-caja/src/ant-reports/coverage/index.html] ... [junitreport] Transform time: 2158ms BUILD SUCCESSFUL Total time: 1 minute 4 seconds Buildfile: build.xml dirs: Primitives: Reporting: Lexer: Parser: CssParserCore: HtmlParserCore: HtmlSchema: JsParserBase: JsParserCore: Quasiliterals: Config: PluginCompiler: opensocial: pluginc: [unjar] Expanding: /opt/svn/google-caja/src/third_party/java/jakarta_commons/commons-cli.jar into /opt/svn/google-caja/src/ant-lib [unjar] Expanding: /opt/svn/google-caja/src/third_party/java/htmlparser/htmlparser.jar into /opt/svn/google-caja/src/ant-lib [jar] Building jar: /opt/svn/google-caja/src/ant-jars/pluginc.jar PluginCapabilities: TestUtil: CajoledTests: [java] LOG:Checkpoint: ValidateCssStage at T+0.181435 seconds [java] LOG:Checkpoint: CompileGxpsStage at T+0.186167 seconds [java] LOG:Checkpoint: CompileCssTemplatesStage at T+0.202458 seconds [java] LOG:Checkpoint: ConsolidateCodeStage at T+0.202521 seconds [java] LOG:Checkpoint: ValidateJavascriptStage at T+0.205435 seconds [java] LOG:Checkpoint: ConsolidateCssStage at T+1.069825 seconds [java] LOG:Checkpoint: CheckForErrorsStage at T+1.06989 seconds AllTests: runtests: [junit] Running com.google.caja.config.ConfigUtilTest [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0.178 sec [junit] Running com.google.caja.demos.calendar.HcalTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 131.928 sec [junit] Running com.google.caja.demos.calendar.RRuleTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 3.342 sec [junit] Running com.google.caja.lexer.CharProducerTest [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.083 sec [junit] Running com.google.caja.lexer.CommentLexerTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.084 sec [junit] Running com.google.caja.lexer.CssLexerTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.143 sec [junit] Running com.google.caja.lexer.HtmlLexerTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.105 sec [junit] Running com.google.caja.lexer.JsLexerTest [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 0.092 sec [junit] Running com.google.caja.lexer.LookaheadCharProducerTest [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.039 sec [junit] Running com.google.caja.lexer.PunctuationTrieTest [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.04 sec [junit] Running com.google.caja.lexer.escaping.EscapingTest [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.046 sec [junit] Running com.google.caja.opensocial.DefaultGadgetRewriterTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 1.38 sec [junit] Running com.google.caja.opensocial.GadgetParserTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.127 sec [junit] Running com.google.caja.parser.ParseTreeNodeTest [junit] Tests run: 38, Failures: 0, Errors: 0, Time elapsed: 0.077 sec [junit] Running com.google.caja.parser.css.Css2Test [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.109 sec [junit] Running com.google.caja.parser.css.CssParserTest [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.205 sec [junit] Running com.google.caja.parser.css.CssTreeTest [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.204 sec [junit] Running com.google.caja.parser.html.DomParserTest [junit] Tests run: 40, Failures: 0, Errors: 0, Time elapsed: 0.268 sec [junit] Running com.google.caja.parser.html.JsHtmlParserTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.178 sec [junit] Running com.google.caja.parser.js.ParserTest [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.366 sec [junit] Running com.google.caja.parser.js.StringLiteralTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 1.251 sec [junit] Running com.google.caja.parser.quasiliteral.DefaultCajaRewriterTest [junit] Tests run: 83, Failures: 0, Errors: 0, Time elapsed: 2.577 sec [junit] Running com.google.caja.parser.quasiliteral.MatchTest [junit] Tests run: 19, Failures: 0, Errors: 0, Time elapsed: 0.185 sec [junit] Running com.google.caja.parser.quasiliteral.QuasiBuilderTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.118 sec [junit] Running com.google.caja.parser.quasiliteral.ScopeTest [junit] Tests run: 14, Failures: 0, Errors: 0, Time elapsed: 0.148 sec [junit] Running com.google.caja.plugin.CompiledPluginTest [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 3.438 sec [junit] Running com.google.caja.plugin.CssRewriterTest [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0.274 sec [junit] Running com.google.caja.plugin.CssValidatorTest [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 0.287 sec [junit] Running com.google.caja.plugin.ExpressionSanitizerTest [junit] Tests run: 22, Failures: 14, Errors: 0, Time elapsed: 0.931 sec [junit] Test com.google.caja.plugin.ExpressionSanitizerTest FAILED [junit] Running com.google.caja.plugin.GxpCompilerTest [junit] Tests run: 23, Failures: 0, Errors: 0, Time elapsed: 0.47 sec [junit] Running com.google.caja.plugin.GxpValidatorTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.105 sec [junit] Running com.google.caja.plugin.HtmlCompiledPluginTest [junit] Tests run: 19, Failures: 0, Errors: 0, Time elapsed: 5.117 sec [junit] Running com.google.caja.plugin.HtmlSanitizerTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.455 sec [junit] Running com.google.caja.plugin.HtmlWhitelistTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.034 sec [junit] Running com.google.caja.plugin.PluginCompilerTest [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.582 sec [junit] Running com.google.caja.plugin.UrlUtilTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.034 sec [junit] Running com.google.caja.plugin.caps.CapabilityRewriterTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.306 sec [junit] Running com.google.caja.util.JoinTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.032 sec [junit] Running com.google.caja.util.SparseBitSetTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.156 sec [junitreport] Transform time: 1184ms BUILD SUCCESSFUL Total time: 2 minutes 55 seconds Buildfile: build.xml docs: [javadoc] Generating Javadoc [javadoc] Javadoc execution [javadoc] Loading source files for package com.google.caja... [javadoc] Loading source files for package com.google.caja.config... [javadoc] Loading source files for package com.google.caja.html... [javadoc] Loading source files for package com.google.caja.lexer... [javadoc] Loading source files for package com.google.caja.lexer.escaping... [javadoc] Loading source files for package com.google.caja.opensocial... [javadoc] Loading source files for package com.google.caja.parser... [javadoc] Loading source files for package com.google.caja.parser.css... [javadoc] Loading source files for package com.google.caja.parser.html... [javadoc] Loading source files for package com.google.caja.parser.js... [javadoc] Loading source files for package com.google.caja.parser.quasiliteral... [javadoc] Loading source files for package com.google.caja.plugin... [javadoc] Loading source files for package com.google.caja.plugin.stages... [javadoc] Loading source files for package com.google.caja.reporting... [javadoc] Loading source files for package com.google.caja.util... [javadoc] Constructing Javadoc information... [javadoc] Standard Doclet version 1.6.0_01 [javadoc] Building tree for all the packages and classes... [javadoc] /opt/svn/google-caja/src/java/com/google/caja/config/ConfigUtil.java:134: warning - @param argument "value" is not a parameter name. [javadoc] /opt/svn/google-caja/src/java/com/google/caja/config/ConfigUtil.java:134: warning - Tag @link: reference not found: MessageType#ERROR [javadoc] /opt/svn/google-caja/src/java/com/google/caja/config/ConfigUtil.java:157: warning - Tag @link: reference not found: MessageType#ERROR [javadoc] /opt/svn/google-caja/src/java/com/google/caja/config/ConfigUtil.java:364: warning - Tag @link: reference not found: MessageLevel#FATAL_ERROR [javadoc] /opt/svn/google-caja/src/java/com/google/caja/config/ConfigUtil.java:364: warning - Tag @link: reference not found: MessageLevel#FATAL_ERROR [javadoc] Building index for all the packages and classes... [javadoc] /opt/svn/google-caja/src/java/com/google/caja/config/ConfigUtil.java:364: warning - Tag @link: reference not found: MessageLevel#FATAL_ERROR [javadoc] Building index for all classes... [javadoc] Generating /opt/svn/google-caja/src/ant-docs/stylesheet.css... [javadoc] 6 warnings BUILD SUCCESSFUL Total time: 9 seconds Buildfile: build.xml dirs: Primitives: Reporting: Lexer: Parser: CssParserCore: HtmlParserCore: HtmlSchema: JsParserBase: JsParserCore: Quasiliterals: Config: PluginCompiler: opensocial: pluginc: [unjar] Expanding: /opt/svn/google-caja/src/third_party/java/jakarta_commons/commons-cli.jar into /opt/svn/google-caja/src/ant-lib [unjar] Expanding: /opt/svn/google-caja/src/third_party/java/htmlparser/htmlparser.jar into /opt/svn/google-caja/src/ant-lib [jar] Building jar: /opt/svn/google-caja/src/ant-jars/pluginc.jar demos: [mkdir] Created dir: /opt/svn/google-caja/src/ant-www/contact-spring-graph/plugin-files [copy] Copying 3 files to /opt/svn/google-caja/src/ant-www/contact-spring-graph [copy] Copying 1 file to /opt/svn/google-caja/src/ant-www/contact-spring-graph [copy] Copying 1 file to /opt/svn/google-caja/src/ant-www/contact-spring-graph [java] Usage: --out=<dir> [--name=<jsIdent>] [--prefix=<cssIdent>] [--pathPrefix=<uriPath>] [java] org.apache.tools.ant.ExitException: Permission (java.lang.RuntimePermission exitVM) was not granted. [java] at org.apache.tools.ant.types.Permissions$MySM.checkExit(Permissions.java:167) [java] at java.lang.Runtime.exit(Runtime.java:88) [java] at java.lang.System.exit(System.java:906) [java] at com.google.caja.plugin.PluginCompilerMain.parseFlags(PluginCompilerMain.java:149) [java] at com.google.caja.plugin.PluginCompilerMain.run(PluginCompilerMain.java:82) [java] at com.google.caja.plugin.PluginCompilerMain.main(PluginCompilerMain.java:386) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:597) [java] at org.apache.tools.ant.taskdefs.ExecuteJava.run(ExecuteJava.java:202) [java] at org.apache.tools.ant.taskdefs.ExecuteJava.execute(ExecuteJava.java:134) [java] at org.apache.tools.ant.taskdefs.Java.run(Java.java:710) [java] at org.apache.tools.ant.taskdefs.Java.executeJava(Java.java:178) [java] at org.apache.tools.ant.taskdefs.Java.execute(Java.java:84) [java] at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:275) [java] at org.apache.tools.ant.Task.perform(Task.java:364) [java] at org.apache.tools.ant.Target.execute(Target.java:341) [java] at org.apache.tools.ant.Target.performTasks(Target.java:369) [java] at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1216) [java] at org.apache.tools.ant.Project.executeTarget(Project.java:1185) [java] at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:40) [java] at org.apache.tools.ant.Project.executeTargets(Project.java:1068) [java] at org.apache.tools.ant.Main.runBuild(Main.java:668) [java] at org.apache.tools.ant.Main.startAnt(Main.java:187) [java] at org.apache.tools.ant.launch.Launcher.run(Launcher.java:246) [java] at org.apache.tools.ant.launch.Launcher.main(Launcher.java:67) BUILD SUCCESSFUL Total time: 4 seconds